refactor: corrected DutyDefinitionSet to match Charon implementation#436
Merged
Conversation
mskrzypkows
changed the title
emlautarom1
reviewed
May 22, 2026
Collaborator
emlautarom1
left a comment
emlautarom1
left a comment
There was a problem hiding this comment.
Could you elaborate on why the change is needed? Why the struct -> trait conversion?
Remember to include a small summary for reviewers, or point to a specific ticket if appropriate.
Contributor
Author
|
Ah, good point that's not really needed. I just need different key for the hashmap: public key instead of duty type. |
…th/pluto into duty_defnition_set_corrected
emlautarom1
approved these changes
May 25, 2026
Collaborator
emlautarom1
left a comment
emlautarom1
left a comment
There was a problem hiding this comment.
I'm fine with this PR, it's an existing issue that was not caught since we haven't ported the clients of this code (ex. core/scheduler). Will probably require further attention though based on usages.
iamquang95
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for the: #179
In charon DutyDefinitionSet is keyed by pubilc key